Piwigo.org

windracer · 2024-04-21 16:41:14

Something in version 14.4.0 has broken my [extension by windracer] Physical Photo Move. When attempting to move physical photos from one album to another, the browser is just locking up (spinner, never seems to finish). I've replicated this on my test and prod Piwigo sites, both running 14.4.0. Nothing in the Piwigo or Apache logs from what I can tell.

The code is hanging when moving the file (using PHP rename function) so it's not even getting to the part where it makes database changes (which is good). I'm seeing a 0 byte file appear in the target directory, and the original is still in the original directory, so I'm thinking it's something with the rename, possibly not Piwigo-related but maybe PHP?

Still debugging to try and figure out the root cause.

Piwigo 14.4.0 Check for upgrade
Installed on 30 January 2017, 7 years 2 months 3 weeks ago
Operating system: Linux
PHP: 8.2.10-2ubuntu1 (Show info) [2024-04-21 10:36:09]
MySQL: 8.3.0 [2024-04-21 10:36:09]
Graphics Library: External ImageMagick 7.1.1-29
Cache size 48.78 Mo   calculated 5 months ago Refresh

Last edited by windracer (2024-04-25 02:35:51)

windracer · 2024-04-21 17:31:00

Not sure if this is related, but I can produce the same problem (hanging browser spinner) when trying to use the Rotate tab on an image. I'm trying to rotate a photo 90 degrees and it just spins, nothing in the logs.

Even disabled my extension and the Rotate problem still happens, so maybe this is some root cause that's not actually a problem with my extension?

windracer · 2024-04-21 18:17:25

Hmm, seems like all the testing I was doing caused a bunch of the apache processes on my Linux box to also lock up. Couldn't kill 'em, couldn't stop the service, and they were causing high load (doing nothing?). I had to reboot the server to clean it up. Very odd.

evadim · 2024-04-21 21:52:49

Maybe some local filesystem issue?

Reminds me NFS behavior...

windracer · 2024-04-22 02:56:49

Possibly, but odd that it started after the 14.4.0 upgrade. Wasn't able to figure anything out today, will continue to investigate this week as I have time.

windracer · 2024-04-22 22:29:19

If anyone else using my extension sees this, can you please let me know if you're having any issue with it since upgrading to Piwigo 14.4.0?

windracer · 2024-04-25 01:02:38

Ok, this looks like a Linux kernel issue, not something with Piwigo 14.4.0 and my extension. I found some errors in my kern.log and syslog that matched the time of when I was reproducing the problem and noticed:

Code:

2024-04-24T17:52:21.051505-04:00 nucleus kernel: [279236.015117] RIP: 0010:cifs_flush_folio+0x41/0xf0 [cifs]

Which led me here: https://bugs.launchpad.net/ubuntu/+sour … ug/2060919

So it's a kernel issue plus the fact that my photos are on a Synology NAS mounted to the Linux server and then used by Piwigo via symlinks.

Ubuntu 24.04 is supposed to come out tomorrow (which uses the 6.8 kernel) so maybe that will fix it for me.

Last edited by windracer (2024-04-25 01:07:53)

windracer · 2024-04-25 02:14:58

Using the patched kernel from the PPA (6.5.0-27-generic #28+TEST2060919v20240419b1-Ubuntu SMP PREEMPT_DYNAMIC Fri Apr 19) resolved the issue for me, so this isn't a bug with the extension. Hopefully the patch makes it into the kernel soon.

To re-iterate, you'd probably only see the issue if you were running Piwigo on Ubuntu with Linux kernel 6.5.0-28, had your photos on a SMB/CIFS mount, AND were using my physical photo move extension.

Last edited by windracer (2024-04-25 13:35:16)

erAck · 2024-04-25 11:31:42

Nice find.

To be precise, it's an Ubuntu-only kernel bug because they applied a 6.1 patch wrongly to their 6.5.0 kernel.

windracer · 2024-04-25 13:37:13

Good point, updated my message above accordingly.

This is also why the Rotate feature on the photo details was hanging my Piwigo installation, so same root cause with CIFS.

Piwigo.org

Announcement

#1 2024-04-21 16:41:14

[resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#2 2024-04-21 17:31:00

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#3 2024-04-21 18:17:25

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#4 2024-04-21 21:52:49

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#5 2024-04-22 02:56:49

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#6 2024-04-22 22:29:19

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#7 2024-04-25 01:02:38

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

Code:

#8 2024-04-25 02:14:58

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#9 2024-04-25 11:31:42

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

#10 2024-04-25 13:37:13

Re: [resolved] 14.4.0 broke my Physical Photo Move extension (Linux kernel issue)

Board footer